Cupertino { TabScafold, TextSelection, TextField } dark mode & minor fidelity update#41431
Merged
LongCatIsLooong merged 20 commits intoflutter:masterfrom Oct 7, 2019
Merged
Conversation
fluttergithubbot
added
f: cupertino
LongCatIsLooong
requested review from
HansMuller,
darrenaustin and
justinmc
LongCatIsLooong
added
c: API break
LongCatIsLooong
changed the title
justinmc
approved these changes
Sep 30, 2019
| const EdgeInsets _kToolbarButtonPadding = EdgeInsets.symmetric(vertical: 10.0, horizontal: 18.0); | ||
| const Radius _kToolbarBorderRadius = Radius.circular(8); | ||
| // Colors extracted from https://developer.apple.com/design/resources/. | ||
| // TODO(LongCatIsLooong): https://github.com/flutter/flutter/issues/41507. |
Contributor
There was a problem hiding this comment.
Thanks for noticing this and creating the issue.
LongCatIsLooong
added a commit
to flutter/goldens
that referenced
this pull request
Oct 2, 2019
18 tasks
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated dark mode colors. Text editing menu color is still not correct: #41507. The color of the clear button seems to have changed in iOS 13.1 so might be different from what you see on iOS 13.0 devices/simulators.
Screenshots
Related Issues
#35541
Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?