Exit resident web runner on compilation failure#41441
Merged
jonahwilliams merged 1 commit intoflutter:masterfrom Sep 27, 2019
Merged
Exit resident web runner on compilation failure#41441jonahwilliams merged 1 commit intoflutter:masterfrom
jonahwilliams merged 1 commit intoflutter:masterfrom
Conversation
fluttergithubbot
added
the
tool
jonahwilliams
added
platform-web
Codecov Report
@@ Coverage Diff @@
## master #41441 +/- ##
==========================================
- Coverage 60% 59.62% -0.39%
==========================================
Files 193 193
Lines 18832 18840 +8
==========================================
- Hits 11301 11233 -68
- Misses 7531 7607 +76
Continue to review full report at Codecov.
|
yjbanov
approved these changes
Sep 27, 2019
jonahwilliams
pushed a commit
that referenced
this pull request
Sep 27, 2019
…)" This reverts commit a1852a1.
jonahwilliams
pushed a commit
that referenced
this pull request
Sep 27, 2019
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We weren't tracking the initial compilation state, so an initial error would leave the app stuck. Instead we should exit and display the error.
Fixes #41433