Pass Linux build mode on command line#41551
Merged
stuartmorgan-g merged 1 commit intoflutter:masterfrom Sep 30, 2019
Merged
Conversation
Currently Linux builds override the default BUILD mode by putting it in the generated config. That makes it sticky for manual runs of make, which is inconsistent with how other platforms work. Instead, pass the build mode as a command-line override, the same way someone would if building directly with make. This makes the flow of controlling the mode less confusing. Fixes flutter#41528
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
Currently Linux builds override the default BUILD mode by putting it in the generated config. That makes it sticky for manual runs of make, which is inconsistent with how other platforms work. Instead, pass the build mode as a command-line override, the same way someone would if building directly with make. This makes the flow of controlling the mode less confusing. Fixes flutter#41528
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently Linux builds override the default BUILD mode by putting it in
the generated config. That makes it sticky for manual runs of make,
which is inconsistent with how other platforms work.
Instead, pass the build mode as a command-line override, the same way
someone would if building directly with make. This makes the flow of
controlling the mode less confusing.
Minor incidental cleanup:
runInShell: truefrom themakecall, as it's not needed, and running through the shell is generally more error-prone.profilefor Profile builds, rather thanrelease. It currently won't build differently, but it's one less place that there's a hard-coded bypass of profile mode to clean up later.Related Issues
Fixes #41528
Tests
I added the following tests: verify that release, profile, and debug all pass the correct override.
Also pulled some common test setup for the Linux build tests into helper functions.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?