Include embedding transitive dependencies in plugins#41885
Merged
jonahwilliams merged 1 commit intoflutter:masterfrom Oct 4, 2019
Merged
Include embedding transitive dependencies in plugins#41885jonahwilliams merged 1 commit intoflutter:masterfrom
jonahwilliams merged 1 commit intoflutter:masterfrom
Conversation
fluttergithubbot
added
the
tool
matthew-carroll
approved these changes
Oct 3, 2019
Contributor
|
Do we need some kind of test for this? Not sure what it would look like...maybe an example app? |
Author
|
@matthew-carroll example app won't help. It would need to be a plugin using the new embedding, which is what @mklim found out. |
mklim
approved these changes
Oct 3, 2019
Contributor
mklim
left a comment
mklim
left a comment
There was a problem hiding this comment.
LGTM.
I patched this locally to test and it fixed my issue.
13 tasks
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed for the new embedding.
Test
This will be tested in the plugins repo once the plugins are migrated to the new embedding.