Revert ActivateAction PR#41945
Merged
jonahwilliams merged 2 commits intoflutter:masterfrom Oct 4, 2019
Merged
Conversation
fluttergithubbot
added
f: material design
gspencergoog
force-pushed
the
activate_regression
branch
from
09efc6c to
a758808
Compare
Contributor
Author
|
I'm also reverting the shortcuts for keyboard traversal (#40186), since they won't function properly unless the |
gspencergoog
force-pushed
the
activate_regression
branch
from
5d36193 to
8b54a03
Compare
Codecov Report
@@ Coverage Diff @@
## master #41945 +/- ##
==========================================
- Coverage 59.31% 58.69% -0.62%
==========================================
Files 194 193 -1
Lines 18934 18882 -52
==========================================
- Hits 11230 11083 -147
- Misses 7704 7799 +95
Continue to review full report at Codecov.
|
This was referenced Oct 8, 2019
1 task
gspencergoog
added a commit
that referenced
this pull request
Oct 10, 2019
This attempts to reland #40186 and #41220, that were reverted in #41945. The main modifications from the original PRs are that I predefine the shortcuts and actions maps instead of defining them inline in the build function, and I use a new mapEquals to do a deep comparison so that we don't rebuild modified things if the contents of the map haven't changed. I also eliminated an operator== and hashCode that were defined on the Actions widget, since widgets shouldn't have those. (it's too bad though: I get an 85% speedup if we leave this in! Too bad it prevents rebuilding of the children...) Fixes #40101
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
This attempts to reland flutter#40186 and flutter#41220, that were reverted in flutter#41945. The main modifications from the original PRs are that I predefine the shortcuts and actions maps instead of defining them inline in the build function, and I use a new mapEquals to do a deep comparison so that we don't rebuild modified things if the contents of the map haven't changed. I also eliminated an operator== and hashCode that were defined on the Actions widget, since widgets shouldn't have those. (it's too bad though: I get an 85% speedup if we leave this in! Too bad it prevents rebuilding of the children...) Fixes flutter#40101
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #41220 because of a performance regression in
microbenchmarks_stock_build_iteration(#41919). Will investigate and re-land next week.Fixes #41919