Add use_modular_headers! to default Podfile#42204
Merged
jmagman merged 1 commit intoflutter:masterfrom Oct 15, 2019
Merged
Conversation
jmagman
added
platform-ios
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
fluttergithubbot
added
d: examples
Codecov Report
@@ Coverage Diff @@
## master #42204 +/- ##
==========================================
+ Coverage 59.93% 60.11% +0.18%
==========================================
Files 194 194
Lines 18877 18877
==========================================
+ Hits 11313 11348 +35
+ Misses 7564 7529 -35
Continue to review full report at Codecov.
|
Member
Author
|
Wow this is a nifty and helpful analyzer warning! Very few Generated files are actually checked in. 🤔 |
jmagman
changed the title
jmagman
commented
Oct 10, 2019
Member
Author
There was a problem hiding this comment.
Swift plugins should not need to add an Objective-C header if they don't need it.
jmagman
changed the title
jmagman
force-pushed
the
modular-headers
branch
from
ef9dd70 to
d525bd2
Compare
christopherfujino
approved these changes
Oct 14, 2019
Contributor
christopherfujino
left a comment
christopherfujino
left a comment
There was a problem hiding this comment.
weak LGTM, given I had to stack overflow search most of what was going on :)
jmagman
force-pushed
the
modular-headers
branch
from
d525bd2 to
893d28f
Compare
9 tasks
9 tasks
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
use_modular_headers!to the default Podfile. Hopefully this lets Swift removeuse_frameworks!and build as libraries in the future (soon?). Compilation times will be faster because clang can use the module cache instead of doing pre-processing work. See http://blog.cocoapods.org/CocoaPods-1.5.0/ for how this works.NS_ASSUME_NONNULL_BEGINto get a compilation warning on a nilregistrysince the registration methods it calls require nonnull.#ifndef GeneratedPluginRegistrant_hin the same spot but I realized we couldn't because the template was using#includeinstead of#import. Migrate them over to avoid including headers multiple times.Related Issues
See #41007 for what supporting modules will unlock.
Tests
I updated the integration test Podfiles.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change