Re-land keyboard traversal PRs#42278
Merged
gspencergoog merged 6 commits intoflutter:masterfrom Oct 10, 2019
Merged
Conversation
fluttergithubbot
added
f: cupertino
Codecov Report
@@ Coverage Diff @@
## master #42278 +/- ##
==========================================
- Coverage 60.37% 58.94% -1.44%
==========================================
Files 194 194
Lines 18849 18845 -4
==========================================
- Hits 11381 11109 -272
- Misses 7468 7736 +268
Continue to review full report at Codecov.
|
Closed
gspencergoog
force-pushed
the
activate_regression
branch
3 times, most recently
from
23bb8dc to
f184aab
Compare
gspencergoog
force-pushed
the
activate_regression
branch
from
f184aab to
5544db4
Compare
gspencergoog
force-pushed
the
activate_regression
branch
from
5544db4 to
b06c773
Compare
darrenaustin
approved these changes
Oct 10, 2019
Contributor
darrenaustin
left a comment
darrenaustin
left a comment
There was a problem hiding this comment.
A lot here, but it LGTM.
Contributor
|
This commit was identified as a potential cause of a benchmark regression. This is tracked in #42564. |
This was referenced Oct 15, 2019
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
This attempts to reland flutter#40186 and flutter#41220, that were reverted in flutter#41945. The main modifications from the original PRs are that I predefine the shortcuts and actions maps instead of defining them inline in the build function, and I use a new mapEquals to do a deep comparison so that we don't rebuild modified things if the contents of the map haven't changed. I also eliminated an operator== and hashCode that were defined on the Actions widget, since widgets shouldn't have those. (it's too bad though: I get an 85% speedup if we leave this in! Too bad it prevents rebuilding of the children...) Fixes flutter#40101
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This attempts to reland #40186 and #41220, that were reverted in #41945.
The main modifications from the original PRs are that I predefine the shortcuts and actions maps instead of defining them inline in the build function, and I use a new
mapEqualsto do a deep comparison so that we don't rebuild modified things if the contents of the map haven't changed.I also eliminated an
operator==andhashCodethat were defined on theActionswidget, since widgets shouldn't have those. (it's too bad though: I get an 85% speedup if we leave this in! Too bad it prevents rebuilding of the children...)Related Issues
#41919
Fixes #40101
Tests
collections.dartfunctionssetEquals,listEquals, and the newmapEquals.Breaking Change