It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Thank you @jonahwilliams for the quick comment! Can you please give me a link to the existing test that I can reference?

Hmm, I was sure what existing test cases that cover these. At any rate, what you'll likely want are two tests.

One for iOS in https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/general.shard/ios/devices_test.dart which calls startApp and ensures that the command line args are correctly set. Specifically, something like https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/general.shard/ios/devices_test.dart#L172 but with assertions on the command line arguments.

Another one for Android in https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/general.shard/android/android_device_test.dart . Unfortunately we don't have an existing one, but it would look much like the iOS tests.

To run a single test in the tools repo, you can run bin/cache/dart-sdk/bin/pub run test path/to/test

Codecov Report

Merging #42353 into master will decrease coverage by 0.12%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master   #42353      +/-   ##
==========================================
- Coverage   59.94%   59.81%   -0.13%     
==========================================
  Files         194      194              
  Lines       18871    18997     +126     
==========================================
+ Hits        11313    11364      +51     
- Misses       7558     7633      +75

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fea283...73817e0. Read the comment docs.

@jonahwilliams : tests added.

@jonahwilliams : friendly ping...