Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

I do not think "isDismissible" is a good variable name.

I do not know whether Flutter project has any naming convention for boolean variables but "is" is a verb, and verbs are inappropriate to represent an object's state.

Therefore "isDismissible" should simply become "dismissible".

You should only use verbs for accessor (getter / setter) methods where it makes more sense when boolean variable is an adjective.

@genert

is_ is a common verb name for booleans in dart. Non-imperative verb phrases are preferred for boolean names.

https://dart.dev/guides/language/effective-dart/design#prefer-a-non-imperative-verb-phrase-for-a-boolean-property-or-variable

@johnsonmh Interesting, thanks for the reference.

But if you look further, you find this - https://dart.dev/guides/language/effective-dart/design#consider-omitting-the-verb-for-a-named-boolean-parameter

For named parameters that are boolean, the name is often just as clear without the verb, and the code reads better at the call site.

Example:

Isolate.spawn(entryPoint, message, paused: false);
var copy = List.from(elements, growable: true);
var regExp = RegExp(pattern, caseSensitive: false);

Which is succinct as verb doesn't give any new information as stated in the documentation. Compare to:

Isolate.spawn(entryPoint, message, isPaused: false);
var copy = List.from(elements, isGrowable: true);
var regExp = RegExp(pattern, isCaseSensitive: false);

Since "isDismissable" is named parameter, then this rule should apply.

@genert I do agree that the parameter name dismissible is sufficient to explain the desired behavior change. However, considering the other existing parameters all have verb prepended in front of them, I'm leaning toward going for consistency since the added verb does no big harm.
Thanks for pointing out that reference though :)