No multiline password fields#42470
Merged
justinmc merged 5 commits intoflutter:masterfrom Oct 28, 2019
Merged
Conversation
fluttergithubbot
added
f: cupertino
Contributor
|
Thanks for doing this! FYI: the breaking change announcement has already been sent to flutter-announce. |
Contributor
Author
|
Oh I see it, thanks for sending that out! Should save some time. |
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
Use assertions to prevent multiline password fields from being created
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is no reason to have a multiline password field, and ours appears broken now, so this PR prevents it from being created and informs the developer.
Related Issues
Closes #41853
Tests
Tested that an assertion is thrown for multiline and obscureText.