Add enableSuggestions flag to TextField and TextFormField by justinmc · Pull Request #42550 · flutter/flutter

justinmc · 2019-10-11T20:48:16Z

Description

Currently there is no direct control over the TYPE_TEXT_FLAG_NO_SUGGESTIONS flag in Android. This PR adds a enableSuggestions flag to all types of text fields to control this Android flag.

Related Issues

Closes #22828
Closes #41758
Depends on engine PR: flutter/engine#13099

Tests

Testing that the property is set and that it goes to the engine correctly. I don't think there's a more thorough way to test that.

fluttergithubbot · 2019-10-11T20:48:18Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

blindjoedeath · 2019-10-11T21:11:51Z

Dude, you are doing the great job!!!! God bless your soul..
This is really important for my recent project.

justinmc · 2019-10-11T21:23:42Z

No problem! 🎉 I'm trying to figure out some tests for this and then it should be ready for code review.

justinmc · 2019-10-11T21:46:54Z

Is noSuggestions a good name? Just mirroring the Android name (and the negative). We could also go with something like keyboardSuggestions or allowKeyboardSuggestions and invert it. I'm not strongly opinionated.

jonahwilliams · 2019-10-11T21:52:46Z

I think it would be better to state it in the positive, rather than be consistent with a (IMO) bad API.

justinmc · 2019-10-11T22:08:43Z

Thanks @jonahwilliams, I'm on board with that. I'll plan to change it to enableKeyboardSuggestions unless anyone else disagrees?

blindjoedeath · 2019-10-16T20:16:02Z

@justinmc How is your work going? Is it possible to get your commits in near future?:)

justinmc · 2019-10-21T18:24:38Z

Sorry for the delay! I'm changing the name to enableSuggestions. The engine PR should be able to be merged in the next few hours, and then this PR can follow.

HansMuller

LGTM

HansMuller · 2019-10-21T22:50:27Z

packages/flutter/lib/src/services/text_input.dart

  final bool autocorrect;

+  /// {@template flutter.services.textInput.enableSuggestions}
+  /// Whether to hide suggestions.


Could we provide a brief explanation of what "suggestions" actually are?

HansMuller · 2019-10-21T22:50:59Z

packages/flutter/lib/src/services/text_input.dart

+  /// {@template flutter.services.textInput.enableSuggestions}
+  /// Whether to hide suggestions.
+  ///
+  /// This flag only affects Android. On iOS, suggestions are tied directly to


Maybe link "Android" to the native doc that describes the feature we depend on.

SiyrisSoul · 2019-10-24T21:39:08Z

What's the status on this?

justinmc · 2019-10-24T22:17:06Z

Just waiting for the build to be green so I can merge this.

I just verified with the engine on master that this branch works and passes the flag correctly, so everything is good to go.

) This flag controls Android's keyboard suggestions on/off

YaseenAbdullah · 2020-05-07T15:05:43Z

i still have this issue why? isn't it fixed?

justinmc · 2020-05-07T15:55:54Z

What version are you using? I think this is in v1.16.3 and above.

YaseenAbdullah · 2020-05-07T16:08:23Z

What version are you using? I think this is in v1.16.3 and above.

Latest version 1.17.0, i updated it last night

justinmc · 2020-05-07T16:19:23Z

Hmm thanks for checking. Does the flag TYPE_TEXT_FLAG_NO_SUGGESTIONS solve your problem in native Android? It looks like you're using the default Gboard keyboard, and I was seeing it ignore that flag even in a native app when I tested this.

YaseenAbdullah · 2020-05-07T16:23:06Z

Hmm thanks for checking. Does the flag TYPE_TEXT_FLAG_NO_SUGGESTIONS solve your problem in native Android? It looks like you're using the default Gboard keyboard, and I was seeing it ignore that flag even in a native app when I tested this.

I didn't tested it in native android but i use SwiftKey in my physical device it's the same

YaseenAbdullah · 2020-05-07T16:55:29Z

any hint how to make it work? I really need it in my project

UPDATE: used keyboardType: TextInputType.visiblePassword for now it does what I want..

justinmc · 2020-05-07T18:56:17Z

See this comment: #22828 (comment)

If your problem is the same as that, then it might not be possible to achieve even on native Android. If Flutter is missing something that native has we can look into adding support, though.

NickalasB · 2021-02-04T23:50:49Z

FWIW setting enableSuggestions:false doesn't work for me either. I'm using Pixel 3/Android 11

[✓] Flutter (Channel stable, 1.22.5, on Mac OS X 10.15.7 19H114 darwin-x64, locale en-US)

This issue #22828 outlines the issue but was closed after this was merged

RE this 👇 :

UPDATE: used keyboardType: TextInputType.visiblePassword for now it does what I want..

That DOES work but on Android it disables the microphone... which is undesirable

justinmc added 2 commits October 11, 2019 13:33

Add noSuggestions flag to TextField

5ee61a2

Add noSuggestions to TextFormField

03a6adb

justinmc added a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. f: cupertino flutter/packages/flutter/cupertino repository work in progress; do not review labels Oct 11, 2019

justinmc self-assigned this Oct 11, 2019

fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label Oct 11, 2019

googlebot added the cla: yes label Oct 11, 2019

Add noSuggestions to CupertinoTextField

ac19374

justinmc force-pushed the no-suggestions branch from 77b290f to ac19374 Compare October 11, 2019 20:53

Test

925fc3b

justinmc changed the title ~~WIP Add noSuggestions flag to TextField and TextFormField~~ Add noSuggestions flag to TextField and TextFormField Oct 11, 2019

justinmc removed the work in progress; do not review label Oct 11, 2019

justinmc mentioned this pull request Oct 11, 2019

NO_SUGGESTIONS keyboard flag in Android flutter/engine#13099

Merged

justinmc requested a review from HansMuller October 11, 2019 21:40

justinmc mentioned this pull request Oct 11, 2019

TextField: "autocorrect: false" still shows suggestions in keyboard #22828

Closed

Rename noSuggestions to enableSuggestions

eb06ed0

HansMuller changed the title ~~Add noSuggestions flag to TextField and TextFormField~~ Add enableSuggestions flag to TextField and TextFormField Oct 21, 2019

HansMuller approved these changes Oct 21, 2019

View reviewed changes

justinmc added 2 commits October 22, 2019 08:44

Code review docs improvements and inversion

9785efb

Merge branch 'master' into no-suggestions

83230d5

justinmc merged commit 6e888da into flutter:master Oct 28, 2019

justinmc deleted the no-suggestions branch October 28, 2019 22:31

justinmc mentioned this pull request Nov 11, 2019

Obfuscated text fields should disable the IME autocorrect (iOS) #26684

Closed

Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019

Add enableSuggestions flag to TextField and TextFormField (flutter#42550

a105a65

) This flag controls Android's keyboard suggestions on/off

NickalasB mentioned this pull request Feb 5, 2021

[text_field]: enableSuggestions:false is not honored on Android #75462

Closed

bleroux mentioned this pull request Dec 4, 2024

[iOS] option to enable suggestions with autocorrect off flutter/engine#56859

Closed

7 tasks

jmagman mentioned this pull request Dec 20, 2024

No way to disable autocorrection and leave the auto-suggest bar visible on iOS with TextField #159584

Closed

Conversation

justinmc commented Oct 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Tests

Uh oh!

fluttergithubbot commented Oct 11, 2019

Uh oh!

blindjoedeath commented Oct 11, 2019

Uh oh!

justinmc commented Oct 11, 2019

Uh oh!

justinmc commented Oct 11, 2019

Uh oh!

jonahwilliams commented Oct 11, 2019

Uh oh!

justinmc commented Oct 11, 2019

Uh oh!

blindjoedeath commented Oct 16, 2019

Uh oh!

justinmc commented Oct 21, 2019

Uh oh!

HansMuller left a comment

Choose a reason for hiding this comment

Uh oh!

HansMuller Oct 21, 2019

Choose a reason for hiding this comment

Uh oh!

HansMuller Oct 21, 2019

Choose a reason for hiding this comment

Uh oh!

SiyrisSoul commented Oct 24, 2019

Uh oh!

justinmc commented Oct 24, 2019

Uh oh!

YaseenAbdullah commented May 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

justinmc commented May 7, 2020

Uh oh!

YaseenAbdullah commented May 7, 2020

Uh oh!

justinmc commented May 7, 2020

Uh oh!

YaseenAbdullah commented May 7, 2020

Uh oh!

YaseenAbdullah commented May 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

justinmc commented May 7, 2020

Uh oh!

NickalasB commented Feb 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

justinmc commented Oct 11, 2019 •

edited

Loading

YaseenAbdullah commented May 7, 2020 •

edited

Loading

YaseenAbdullah commented May 7, 2020 •

edited

Loading

NickalasB commented Feb 4, 2021 •

edited

Loading