Skip to content

Revert "Roll engine eed171ff3538..00f330068d3e (5 commits) (#42541)"#42551

Merged
gspencergoog merged 1 commit intoflutter:masterfrom
gspencergoog:revert_engine_roll
Oct 11, 2019
Merged

Revert "Roll engine eed171ff3538..00f330068d3e (5 commits) (#42541)"#42551
gspencergoog merged 1 commit intoflutter:masterfrom
gspencergoog:revert_engine_roll

Conversation

@gspencergoog
Copy link
Contributor

@gspencergoog gspencergoog commented Oct 11, 2019

This reverts commit e761607 because it breaks the framework build.

@gspencergoog
Revert "Roll engine eed171f..00f3300 (5 commits) (flutter#42541)"
5d991b8 
This reverts commit e761607 because it breaks the framework build.
@fluttergithubbot fluttergithubbot added the engine flutter/engine related. See also e: labels. label Oct 11, 2019
@codecov
Copy link

codecov bot commented Oct 11, 2019 •
edited
Loading

Codecov Report

Merging #42551 into master will increase coverage by 0.46%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #42551      +/-   ##
==========================================
+ Coverage   59.83%   60.29%   +0.46%     
==========================================
  Files         194      194              
  Lines       18871    18871              
==========================================
+ Hits        11292    11379      +87     
+ Misses       7579     7492      -87
Flag Coverage Δ
#flutter_tool 60.29% <0%> (+0.46%) ⬆️
Impacted Files Coverage Δ
.../flutter_tools/lib/src/commands/build_fuchsia.dart 13.63% <0%> (-68.19%) ⬇️
packages/flutter_tools/lib/src/base/flags.dart 5.55% <0%> (-44.45%) ⬇️
...ges/flutter_tools/lib/src/application_package.dart 55.43% <0%> (-11.6%) ⬇️
...ter_tools/lib/src/fuchsia/application_package.dart 62.96% <0%> (-11.12%) ⬇️
...tools/lib/src/fuchsia/fuchsia_kernel_compiler.dart 0% <0%> (-7.7%) ⬇️
...ges/flutter_tools/lib/src/fuchsia/fuchsia_sdk.dart 67.3% <0%> (-3.85%) ⬇️
packages/flutter_tools/lib/src/artifacts.dart 70.68% <0%> (-0.69%) ⬇️
packages/flutter_tools/lib/src/vmservice.dart 41.06% <0%> (-0.17%) ⬇️
packages/flutter_tools/lib/src/cache.dart 49.18% <0%> (+0.7%) ⬆️
packages/flutter_tools/lib/src/android/gradle.dart 78.44% <0%> (+1.89%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de499c2...5d991b8. Read the comment docs.

@gspencergoog gspencergoog merged commit 8a2762c into flutter:master Oct 11, 2019
@gspencergoog
Copy link
Contributor Author

gspencergoog commented Oct 11, 2019

TBR= @dnfield

@dnfield
Copy link
Contributor

dnfield commented Oct 11, 2019

LGTM. What did this break?

@gspencergoog
Copy link
Contributor Author

gspencergoog commented Oct 11, 2019

The test it broke was flutter_tools/test/general.shard/asset_bundle_test.dart, but this revert didn't fix it, so we're bisecting.

@gspencergoog gspencergoog deleted the revert_engine_roll branch October 15, 2019 21:36
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
@gspencergoog @Inconnu08
Revert "Roll engine eed171f..00f3300 (5 commits) (flutter#42541)" (fl…
3f97ee4 
…utter#42551)

This reverts commit e761607 because it breaks the framework build.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gspencergoog @dnfield @googlebot @fluttergithubbot