Skip to content

Turn off bitcode for integration tests and add-to-app templates#42958

Merged
jmagman merged 2 commits intoflutter:masterfrom
jmagman:bitcode-disable
Oct 25, 2019
Merged

Turn off bitcode for integration tests and add-to-app templates#42958
jmagman merged 2 commits intoflutter:masterfrom
jmagman:bitcode-disable

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Oct 17, 2019

Description

With bitcode enabled, app crashes on launch from a distributed ipa. Disable bitcode in templates and integration tests until it can be fixed.
😞

Related Issues

Revert #39503.
See #42458.

Tests

Make sure add-to-app and module_test_ios still pass.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • Yes, this is a breaking change (Please read [Handling breaking changes]). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@jmagman jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. a: existing-apps Integration with existing apps via the add-to-app flow labels Oct 17, 2019
@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Oct 17, 2019
@codecov
Copy link

codecov bot commented Oct 17, 2019 •
edited
Loading

Codecov Report

Merging #42958 into master will decrease coverage by 0.44%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #42958      +/-   ##
==========================================
- Coverage    60.5%   60.05%   -0.45%     
==========================================
  Files         195      195              
  Lines       19029    18940      -89     
==========================================
- Hits        11513    11374     -139     
- Misses       7516     7566      +50
Flag Coverage Δ
#flutter_tool 60.05% <ø> (-0.45%) ⬇️
Impacted Files Coverage Δ
packages/flutter_tools/lib/src/ios/devices.dart 13.88% <0%> (-61.51%) ⬇️
packages/flutter_tools/lib/src/ios/mac.dart 26.33% <0%> (-27.9%) ⬇️
packages/flutter_tools/lib/src/services.dart 0% <0%> (-24.4%) ⬇️
packages/flutter_tools/lib/src/convert.dart 58.33% <0%> (-8.34%) ⬇️
...lutter_tools/lib/src/build_system/targets/web.dart 51.72% <0%> (-7.1%) ⬇️
...ges/flutter_tools/lib/src/build_system/source.dart 83.67% <0%> (-3.29%) ⬇️
...kages/flutter_tools/lib/src/commands/precache.dart 87.87% <0%> (-3.04%) ⬇️
packages/flutter_tools/lib/src/dart/pub.dart 66.36% <0%> (-1.97%) ⬇️
packages/flutter_tools/lib/src/version.dart 93.23% <0%> (-1.94%) ⬇️
packages/flutter_tools/lib/src/context_runner.dart 67.24% <0%> (-1.73%) ⬇️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1df27f0...c22a228. Read the comment docs.

christopherfujino
christopherfujino approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@christopherfujino
Copy link
Contributor

christopherfujino commented Oct 17, 2019

weird gradle errors on cirrus...

@jmagman jmagman merged commit 41c02d7 into flutter:master Oct 25, 2019
@jmagman
Copy link
Member Author

jmagman commented Oct 25, 2019

Merging on red, device lab failures are due to infra, hosts have been restarted.

@jmagman jmagman deleted the bitcode-disable branch October 25, 2019 01:16
jmagman added a commit to jmagman/flutter that referenced this pull request Nov 12, 2019
@jmagman
Revert "Turn off bitcode for integration tests and add-to-app templat…
1eddbc9 
…es (flutter#42958)"

This reverts commit 41c02d7.
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
@jmagman @Inconnu08
Turn off bitcode for integration tests and add-to-app templates (flut…
ea46087 
…ter#42958)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dnfield dnfield Awaiting requested review from dnfield

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: existing-apps Integration with existing apps via the add-to-app flow c: contributor-productivity Team-specific productivity, code health, technical debt. platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jmagman @christopherfujino @googlebot @fluttergithubbot