comment out fastlane test archiving#43207
Merged
christopherfujino merged 1 commit intoflutter:masterfrom Oct 21, 2019
Merged
Conversation
fluttergithubbot
added
c: contributor-productivity
christopherfujino
force-pushed
the
remove-fastlane
branch
3 times, most recently
from
86ab2b7 to
36859d8
Compare
Codecov Report
@@ Coverage Diff @@
## master #43207 +/- ##
==========================================
- Coverage 61.13% 61.07% -0.06%
==========================================
Files 195 195
Lines 18954 18954
==========================================
- Hits 11587 11577 -10
- Misses 7367 7377 +10
Continue to review full report at Codecov.
|
Contributor
|
FYI you can use Dockerfile as CI Environment with Cirrus for easier upgrades. |
Contributor
Author
|
deploy_gallery-macos passed, so I will land this |
9 tasks
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently cirrus is failing the mac deploy gallery test because fastlane is looking for a version of the Google Cloud SDK newer than that on the docker image. Re-building the docker image is complicated, so I am temporarily commenting out the offending step. Note, that this test will still fail on the next published release until the issue is resolved: #43204.