Migrate examples to the Android embedding v2#43221
Merged
blasten merged 1 commit intoflutter:masterfrom Oct 26, 2019
Merged
Conversation
fluttergithubbot
added
d: examples
Codecov Report
@@ Coverage Diff @@
## master #43221 +/- ##
==========================================
- Coverage 61.51% 60.73% -0.79%
==========================================
Files 195 195
Lines 19016 18954 -62
==========================================
- Hits 11698 11511 -187
- Misses 7318 7443 +125
Continue to review full report at Codecov.
|
blasten
force-pushed
the
migrate_examples_new_embedding
branch
5 times, most recently
from
99d1947 to
d847813
Compare
blasten
force-pushed
the
migrate_examples_new_embedding
branch
from
d847813 to
8ca92f8
Compare
matthew-carroll
approved these changes
Oct 25, 2019
xster
reviewed
Oct 25, 2019
| <category android:name="android.intent.category.LAUNCHER"/> | ||
| </intent-filter> | ||
| </activity> | ||
| <!-- Don't delete the meta-data below. |
Member
There was a problem hiding this comment.
Was this what we decided as opposed to a string search for import "io.flutter.embedding" in the users' java code?
Member
There was a problem hiding this comment.
Sure, SGTM. What happens when there's mismatches? (false positives or negatives)
Author
There was a problem hiding this comment.
I’m hoping we can automize the migration, so apps devs don’t have to modify the manifest manually. But yes, if someone changes this manually without also changing the java code , then the app won’t compile.
blasten
pushed a commit
that referenced
this pull request
Oct 28, 2019
blasten
pushed a commit
to blasten/flutter
that referenced
this pull request
Oct 28, 2019
blasten
pushed a commit
that referenced
this pull request
Oct 28, 2019
* Fix device lab tests * Migrate examples to the Android embedding v2 (#43221)
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
…flutter#43611) This reverts commit b49ffa8.
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
* Fix device lab tests * Migrate examples to the Android embedding v2 (flutter#43221)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrate the examples apps to the Android embedding v2.
Related Issues
Fixes #33884
Related to #43220
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?