[flutter_tool] Use engine flutter_runner prebuilts#43381
[flutter_tool] Use engine flutter_runner prebuilts#43381zanderso merged 2 commits intoflutter:masterfrom zanderso:use-correct-flutter-runner
Conversation
zanderso
added
tool
There was a problem hiding this comment.
that this works blows my mind
There was a problem hiding this comment.
we should use the aot runner
There was a problem hiding this comment.
(can be a separate PR of course)
There was a problem hiding this comment.
Yeah, the tool doesn't know how to build aot Fuchsia packages, yet, so that'll probably be a bigger change.
There was a problem hiding this comment.
Could we link to an example cmx file here?
There was a problem hiding this comment.
Added a cmx file for the stocks example.
There was a problem hiding this comment.
Could this use the existing artifacts.getArtifactPath(...) APIs instead?
There was a problem hiding this comment.
nit: represent this as an enum/class or create const values to avoid stringly-typed issues.
| case Artifact.fuchsiaPlatformDill: | ||
| case Artifact.fuchsiaPatchedSdk: | ||
| case Artifact.fuchsiaFlutterJitRunner: | ||
| assert(false, 'Invalid local engine artifact $artifact.'); |
There was a problem hiding this comment.
@iskakaushik Do you know where these would be in a local engine build?
There was a problem hiding this comment.
Sorry, missed this somehow. They would be in the out/fuchsia_x64_.../flutter_aot_runner.far for example.
|
ptal |
Co-Authored-By: Jonah Williams <[email protected]>
* [flutter_tool] Use engine flutter_runner prebuilts * Update packages/flutter_tools/lib/src/fuchsia/fuchsia_build.dart Co-Authored-By: Jonah Williams <[email protected]>
6 participants
Description
This PR switches Fuchsia targets to use the engine prebuilts instead of the prebuilts bundled with the Fuchsia SDK. The prebuilts bundled with the Fuchsia SDK are to be removed as part of the flutter_runner migration to the engine repo.
Tests
Updated existing tests, and added tests for querying
FuchsiaDevice.targetPlatform.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?