Add macOS to TargetPlatform#43457
Merged
gspencergoog merged 10 commits intoflutter:masterfrom Nov 27, 2019
Merged
Conversation
gspencergoog
added
framework
gspencergoog
force-pushed
the
add_macos_platform
branch
from
55c001e to
ca81173
Compare
fluttergithubbot
added
a: tests
gspencergoog
force-pushed
the
add_macos_platform
branch
2 times, most recently
from
f685d3e to
2a9d056
Compare
Contributor
Contributor
Author
|
Thanks @stuartmorgan, I'll add those changes. |
gspencergoog
force-pushed
the
add_macos_platform
branch
from
f430664 to
d929ff3
Compare
gspencergoog
force-pushed
the
add_macos_platform
branch
3 times, most recently
from
f2b92c2 to
f6a9903
Compare
gspencergoog
force-pushed
the
add_macos_platform
branch
2 times, most recently
from
8f4545f to
937fb9d
Compare
fluttergithubbot
added
d: examples
gspencergoog
removed
d: examples
Contributor
Author
|
Actually, since this doesn't break any tests, this falls under "Class 3" breaking change, where I'll make the change, but send out a notice. Class 3: "Other changes that do not break any tests, but where we can imagine reasonable scenarios where developers would be affected negatively." |
fluttergithubbot
added
d: examples
gspencergoog
removed
d: examples
Contributor
|
Should we just go ahead and pre-emptively add |
Contributor
Author
|
@dnfield No, we're not ready to do that for those platforms yet, since they're not at alpha quality yet. Once they get there, we'll add them. |
This was referenced Jan 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
TargetPlatform.macOSto theTargetPlatformenum. This allows us to begin implementation of some adaptive UI based on which target platform is desired.I haven't updated the tests here, that will come in a follow-up PR.
Related Issues
Addresses part of #31366 (the
macOSpart).Tests
Breaking Change
switchstatement onTargetPlatformwill have to addTargetPlatform.macOSto avoid getting a lint warning and possible runtime problems.