flip track widget creation on by default#43471
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
fluttergithubbot
added
the
tool
|
Waiting to see what this breaks .... |
…ter into enable_twc_by_default
| Cache.flutterRoot = '../..'; | ||
| return _testFile('print_user_created_ancestor_no_flag', automatedTestsDirectory, flutterTestDirectory); | ||
| return _testFile('print_user_created_ancestor_no_flag', automatedTestsDirectory, flutterTestDirectory, | ||
| extraArguments: const <String>['--no-track-widget-creation']); |
There was a problem hiding this comment.
we should run tests with --track-widget-creation by default. It provides a better experience when your tests have rendering errors as you can figure out where in your source code you likely triggered the error.
There was a problem hiding this comment.
Tests use the same track-widget-creation setting so they are on by default too. This test case is just testing the stack traces for twc being off, which is why I needed to switch the flag
jacob314
left a comment
jacob314
left a comment
There was a problem hiding this comment.
Lgtm with a nit that we should be turning this on for tests as well.
4 participants
Description
This should have been flipped a long time ago. Hasn't been noticed since most IDE's specify true by default