Improve DropdownButton assert message#43511
Merged
shihaohong merged 3 commits intoflutter:masterfrom Oct 28, 2019
shihaohong:dropdown-duplicate-assert
Merged
Improve DropdownButton assert message#43511shihaohong merged 3 commits intoflutter:masterfrom shihaohong:dropdown-duplicate-assert
shihaohong merged 3 commits intoflutter:masterfrom
shihaohong:dropdown-duplicate-assert
Conversation
shihaohong
added
framework
HansMuller
approved these changes
Oct 25, 2019
| items.where((DropdownMenuItem<T> item) { | ||
| return item.value == value; | ||
| }).length == 1, | ||
| 'There should be one item with [DropdownButton]\'s value: $value. \n' |
Contributor
There was a problem hiding this comment.
should be one => should be exactly one
| return item.value == value; | ||
| }).length == 1, | ||
| 'There should be one item with [DropdownButton]\'s value: $value. \n' | ||
| 'There might be no [DropdownButtonItem]s with this value, or ' |
Contributor
There was a problem hiding this comment.
This is stated in the same way that the expected (correct) configuration is stated in the first sentence. Might be better to say something like: "Either zero or 2 or more [DropdownMenuItem]s ..."
| } | ||
| }); | ||
|
|
||
| testWidgets('DropdownButton does not item list without given value', (WidgetTester tester) async { |
Contributor
There was a problem hiding this comment.
DropdownButton value should only appear in one menu item
| } | ||
| }); | ||
|
|
||
| testWidgets('DropdownButtonFormField does not item list without given value', (WidgetTester tester) async { |
Contributor
There was a problem hiding this comment.
Same comment about the test title as earlier
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
- Adds an assert message checking for exactly one unique value for `DropdownItem`s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a helpful assert message to DropdownButton for when:
Related Issues
Fixes #43333
Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?