Skip to content

catch failure to parse FLUTTER_STORAGE_BASE_URL#43599

Merged
jonahwilliams merged 2 commits intoflutter:masterfrom
jonahwilliams:fix_uri_parse_check
Oct 28, 2019
Merged

catch failure to parse FLUTTER_STORAGE_BASE_URL#43599
jonahwilliams merged 2 commits intoflutter:masterfrom
jonahwilliams:fix_uri_parse_check

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Oct 27, 2019

Description

If the URI has a leading space or other invalid characters, then currently we'll crash with a FormatException.

FormatException: Scheme not starting with alphabetic character (at character 1)
 https://storage.flutter-io.cn/flutter_infra/flutter/3ebf0069041803955fc002

  | at _Uri._fail | (uri.dart:1623 )
-- | -- | --
  | at _Uri._makeScheme | (uri.dart:2184 )
  | at new _Uri.notSimple | (uri.dart:1465 )
  | at Uri.parse | (uri.dart:1022 )
  | at EngineCachedArtifact.updateInner | (cache.dart:666 )
  | at <asynchronous gap> | (async )
  | at CachedArtifact.update | (cache.dart:460 )
  | at <asynchronous gap> | (async )
  | at Cache.updateAll | (cache.dart:359 )
  | at <asynchronous gap> | (async )
  | at FlutterCommand.verifyThenRunCommand | (flutter_command.dart:537 )
  | at <asynchronous gap> | (async )
  | at FlutterCommand.run.<anonymous closure> | (flutter_command.dart:457 )
  | at <asynchronous gap> | (async )
  | at AppContext.run.<anonymous closure> | (context.dart:157 )
  | at <asynchronous gap> | (async )
  | at _rootRun | (zone.dart:1124 )
  | at _CustomZone.run | (zone.dart:1021 )
  | at _runZoned | (zone.dart:1516 )
  | at runZoned | (zone.dart:1463 )
  | at AppContext.run | (context.dart:156 )
  | at <asynchronous gap> | (async )
  | at FlutterCommand.run | (flutter_command.dart:446 )
  | at CommandRunner.runCommand | (command_runner.dart:197 )
  | at <asynchronous gap> | (async )
  | at FlutterCommandRunner.runCommand.<anonymous closure> | (flutter_command_runner.dart:416 )
  | at <asynchronous gap> | (async )
  | at AppContext.run.<anonymous closure> | (context.dart:157 )
  | at <asynchronous gap> | (async )
  | at _rootRun | (zone.dart:1124 )
  | at _CustomZone.run | (zone.dart:1021 )
  | at _runZoned | (zone.dart:1516 )
  | at runZoned | (zone.dart:1463 )
  | at AppContext.run | (context.dart:156 )
  | at <asynchronous gap> | (async )
  | at FlutterCommandRunner.runCommand | (flutter_command_runner.dart:367 )
  | at <asynchronous gap> | (async )
  | at CommandRunner.run.<anonymous closure> | (command_runner.dart:112 )

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 27, 2019
christopherfujino
christopherfujino approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, lgtm

@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented Oct 28, 2019

nice catch

eyyyyyy

@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented Oct 28, 2019

analyze failure is not real, looks like it is reporting the status of a rescheduled job

@jonahwilliams jonahwilliams merged commit b142c9b into flutter:master Oct 28, 2019
@jonahwilliams jonahwilliams deleted the fix_uri_parse_check branch October 28, 2019 17:54
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
@Inconnu08
catch failure to parse FLUTTER_STORAGE_BASE_URL (flutter#43599)
07f1d87
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jonahwilliams @christopherfujino @googlebot @fluttergithubbot