Skip to content

Revert "Re-Land: Add focus nodes, hover, and shortcuts to switches, checkboxes, and radio buttons. (#43384)"#43647

Merged
gspencergoog merged 1 commit intoflutter:masterfrom
gspencergoog:switch_focus
Oct 28, 2019
Merged

Revert "Re-Land: Add focus nodes, hover, and shortcuts to switches, checkboxes, and radio buttons. (#43384)"#43647
gspencergoog merged 1 commit intoflutter:masterfrom
gspencergoog:switch_focus

Conversation

@gspencergoog
Copy link
Contributor

@gspencergoog gspencergoog commented Oct 28, 2019

This reverts commit 8017f63, since it breaks web tests.

@gspencergoog
Revert "Re-Land: Add focus nodes, hover, and shortcuts to switches, c…
04071ec 
…heckboxes, and radio buttons. (flutter#43384)"

This reverts commit 8017f63, since it breaks web tests.
@fluttergithubbot fluttergithubbot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Oct 28, 2019
@gspencergoog
Copy link
Contributor Author

gspencergoog commented Oct 28, 2019

TBR= @yjbanov

@codecov
Copy link

codecov bot commented Oct 28, 2019 •
edited
Loading

Codecov Report

Merging #43647 into master will decrease coverage by 0.88%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #43647      +/-   ##
==========================================
- Coverage   61.49%   60.61%   -0.89%     
==========================================
  Files         197      197              
  Lines       19192    19192              
==========================================
- Hits        11803    11634     -169     
- Misses       7389     7558     +169
Flag Coverage Δ
#flutter_tool 60.61% <0%> (-0.89%) ⬇️
Impacted Files Coverage Δ
packages/flutter_tools/lib/executable.dart 0% <0%> (-92.86%) ⬇️
packages/flutter_tools/lib/src/base/platform.dart 7.14% <0%> (-57.15%) ⬇️
...es/flutter_tools/lib/src/base/process_manager.dart 9.09% <0%> (-45.46%) ⬇️
...ckages/flutter_tools/lib/src/commands/analyze.dart 0% <0%> (-38.71%) ⬇️
...kages/flutter_tools/lib/src/commands/packages.dart 0% <0%> (-32.66%) ⬇️
...ckages/flutter_tools/lib/src/base/file_system.dart 42.59% <0%> (-25.93%) ⬇️
...ackages/flutter_tools/lib/src/commands/format.dart 0% <0%> (-25%) ⬇️
...tools/lib/src/commands/make_host_app_editable.dart 0% <0%> (-22.23%) ⬇️
packages/flutter_tools/lib/src/commands/train.dart 0% <0%> (-20%) ⬇️
...flutter_tools/lib/src/commands/inject_plugins.dart 0% <0%> (-20%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b31ca1a...04071ec. Read the comment docs.

@gspencergoog gspencergoog merged commit 38f2d27 into flutter:master Oct 28, 2019
@yjbanov
Copy link
Contributor

yjbanov commented Oct 28, 2019

LGTM

Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
@gspencergoog @Inconnu08
Revert "Re-Land: Add focus nodes, hover, and shortcuts to switches, c…
f23b71d 
…heckboxes, and radio buttons. (flutter#43384)" (flutter#43647)

This reverts commit 8017f63, since it breaks web tests.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gspencergoog @yjbanov @googlebot @fluttergithubbot