Re-Land: Add focus nodes, hover, and shortcuts to switches, checkboxes, and radio buttons.#43657
Merged
gspencergoog merged 2 commits intoflutter:masterfrom Oct 30, 2019
Merged
Conversation
fluttergithubbot
added
a: accessibility
gspencergoog
force-pushed
the
switch_focus
branch
3 times, most recently
from
cf961b3 to
f1acd99
Compare
…s, and radio buttons. (flutter#43384) This reverts commit 38f2d27 to fix web tests.
gspencergoog
force-pushed
the
switch_focus
branch
from
f1acd99 to
b05f0c8
Compare
1 task
darrenaustin
approved these changes
Oct 29, 2019
Contributor
darrenaustin
left a comment
darrenaustin
left a comment
There was a problem hiding this comment.
Looking mostly at the changes from the last land attempt, it LGTM!
|
|
||
| // On the web, enter doesn't select things, *except* in a <select> | ||
| // element, which is what a dropdown emulates. | ||
| static final Map<LogicalKeySet, Intent> _webShortcuts =<LogicalKeySet, Intent>{ |
Contributor
There was a problem hiding this comment.
Probably not critical, but this does mean that non-web versions of the app will have this taking up memory, right?
Contributor
Author
There was a problem hiding this comment.
Yes, I guess so: it's not a lot though, since it's static. I'll make it predicated on kIsWeb too and it'll take up less space then.
Contributor
Author
There was a problem hiding this comment.
Actually, since it's a private static, and all uses are within if (kIsWeb){} blocks that will be elided, I'll bet it disappears entirely on non-web platforms.
1 task
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
…s, and radio buttons. (flutter#43657) This re-lands the change that adds focus nodes, hover, and shortcuts to switches, checkboxes, and radio buttons. (flutter#43213), with fixes for the web tests that weren't enabled in the master that it was synced to when I first landed it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This re-lands the change that adds focus nodes, hover, and shortcuts to switches, checkboxes, and radio buttons. (#43213), with fixes for the web tests that weren't enabled in the master that it was synced to when I first landed it.