Move the plugin registrant to io.flutter.plugins and add the @Keep an…#44011
Merged
blasten merged 1 commit intoflutter:masterfrom Nov 1, 2019
Merged
Move the plugin registrant to io.flutter.plugins and add the @Keep an…#44011blasten merged 1 commit intoflutter:masterfrom
blasten merged 1 commit intoflutter:masterfrom
Conversation
c2ecd31 to
a6e9a21
Compare
Author
|
@redbrogdon fyi, the examples now need to import |
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the plugin registrant back to the
io.flutter.pluginsnamespace and adds the @keep annotation, so the class isn't removed by R8.Related Issues
Fixes #43869
Tests
I added the following tests: Updated the unit test.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?