Added tests for the new Android heading semantic flag to android_semantics_testing#44031
Merged
darrenaustin merged 3 commits intoflutter:masterfrom Nov 5, 2019
darrenaustin:android_header_semantics
Merged
Added tests for the new Android heading semantic flag to android_semantics_testing#44031darrenaustin merged 3 commits intoflutter:masterfrom darrenaustin:android_header_semantics
darrenaustin merged 3 commits intoflutter:masterfrom
darrenaustin:android_header_semantics
Conversation
fluttergithubbot
added
a: accessibility
dev/integration_tests/android_semantics_testing/lib/src/tests/headings_constants.dart
Outdated
Show resolved
Hide resolved
dev/integration_tests/android_semantics_testing/test_driver/main_test.dart
Show resolved
Hide resolved
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
…ntics_testing (flutter#44031) Added tests for the new Android heading semantic flag to android_semantics_testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A new feature was added to the semantics support on Android for the
isHeaderflag (flutter/engine#13262). This PR adds new integration tests to automate testing that this flag is properly set for Android.This new field requires Android API 28 or higher to work, but this test was set up to automatically pass if the test is running on anything lower so that is can still work properly until we have a newer device in the device lab (see #44006). I have tested it on both a Moto G 4 and a Pixel 3 and both work fine.
Related Issues
This is to test the fix for #41494.
Tests
A new "Headings" test page was added to the android semantics testing job that runs on devicelab.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?