Skip to content

Add Android embedding version analytics#44043

Merged
xster merged 4 commits intoflutter:masterfrom
xster:add-embedding-version-analytics
Nov 5, 2019
Merged

Add Android embedding version analytics#44043
xster merged 4 commits intoflutter:masterfrom
xster:add-embedding-version-analytics

Conversation

@xster
Copy link
Member

@xster xster commented Nov 2, 2019 •
edited
Loading

Description

Let GA have Android embedding versions on flutter run and flutter packages get

Related Issues

Tests

packages_test

I want to add a run test but as far as I can tell, in its current state, the run command is untestable.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@xster xster requested a review from blasten November 2, 2019 11:03
@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 2, 2019
xster
xster commented Nov 2, 2019
View reviewed changes
packages/flutter_tools/lib/src/reporting/usage.dart Outdated
Copy link
Member Author

@xster xster Nov 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need some help here. I don't know how to add these.

Copy link

@blasten blasten Nov 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add them once you submit this PR.

Copy link
Member Author

@xster xster Nov 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Member Author

@xster xster Nov 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find them in GA. Did you add them?

Copy link

@blasten blasten Nov 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. I just added. It should be possible to retrieve the data even if the custom dimension isn't registered, since GA just uses the index instead of the name to store the data.

Copy link
Member Author

@xster xster Nov 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ummm doesn't seem queriable https://plx.corp.google.com/scripts2/script_5d._cc5d93_0000_2c04_a547_94eb2c112722

Wonder if the GA definition affects BigQuery exporting.

blasten
blasten reviewed Nov 4, 2019
View reviewed changes
packages/flutter_tools/lib/src/project.dart Outdated
Copy link

@blasten blasten Nov 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: indentation

Copy link
Member Author

@xster xster Nov 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

blasten
blasten reviewed Nov 4, 2019
View reviewed changes
packages/flutter_tools/lib/src/plugins.dart Outdated
Copy link

@blasten blasten Nov 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: since it's now using an enum, this switch doesn't need a default case anymore.

Copy link
Member Author

@xster xster Nov 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh right, thanks

blasten
blasten approved these changes Nov 4, 2019
View reviewed changes
Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ minor nits

@xster xster force-pushed the add-embedding-version-analytics branch from 258ab79 to 89ed5f5 Compare November 4, 2019 23:50
@xster xster force-pushed the add-embedding-version-analytics branch from 740ca81 to a38fb41 Compare November 5, 2019 02:04
@xster xster merged commit ba26f92 into flutter:master Nov 5, 2019
@xster xster deleted the add-embedding-version-analytics branch November 5, 2019 20:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@blasten blasten blasten approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xster @blasten @googlebot @fluttergithubbot