Add command key bindings to macOS text editing and fix selection.#44130
Add command key bindings to macOS text editing and fix selection.#44130gspencergoog merged 10 commits intoflutter:masterfrom
Conversation
fluttergithubbot
added
the
framework
gspencergoog
changed the title
gspencergoog
force-pushed
the
add_command_key
branch
3 times, most recently
from
a4fc1a2 to
5fc34cd
Compare
gspencergoog
changed the title
Piinks
added
a: desktop
gspencergoog
force-pushed
the
add_command_key
branch
from
5fc34cd to
e956ff9
Compare
There was a problem hiding this comment.
Seems like this code would result in use computing plain text every time a key is pressed, which it should be cache-able as long as the TextPainter doesn't update. I'm not sure how large the performance impact would be, but it might be an easy win
There was a problem hiding this comment.
I added _plainText that lazily evaluates and caches the plain text version of the text. It didn't add too much complexity (actually seems easier to read to me), and can only result in a win performance-wise. The only danger is that the TextPainter updates its text member somehow without telling the RenderEditable, but I don't think that's possible, since the RenderEditable owns the painter and doesn't expose it.
gspencergoog
force-pushed
the
add_command_key
branch
from
e956ff9 to
60c4f45
Compare
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
I took a quick pass through this one. Generally looks good, but I'm a bit concerned about performance on larger buffers
|
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
6 participants
Description
This adds support for the command key for text selection/editing on macOS. I had ported the text editing code (in #42879), but forgot to add support for the command key itself. This also adds a test that tests the text editing on multiple platforms instead of just testing Android.
There appears to still be a bug (filed #44135) where we're losing key events sometimes on macOS, leaving some keys "stuck" on, but this PR at least allows the right key combinations to be used.
Related Issues
Addresses #30709
Fixes #36316
Tests
Breaking Change