Moving pointer event sanitizing to engine.#44217
Merged
chunhtai merged 7 commits intoflutter:masterfrom Nov 20, 2019
Merged
Conversation
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
fluttergithubbot
added
the
framework
Piinks
added
customer: crowd
chunhtai
force-pushed
the
issues/20517
branch
from
7f3b047 to
9f5b741
Compare
Piinks
reviewed
Nov 15, 2019
Contributor
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
Looks like Cirrus is unhappy. :(
Contributor
Author
|
unfortunately this pr requires flutter/engine#13697 to be merged first. After that the analyzer should pass. I should be able to merge the engine pr soon |
Contributor
Silly me. 😝 |
chunhtai
force-pushed
the
issues/20517
branch
2 times, most recently
from
322e4ce to
9123ffa
Compare
chunhtai
force-pushed
the
issues/20517
branch
from
9123ffa to
3fd7475
Compare
dkwingsmt
added a commit
to dkwingsmt/flutter
that referenced
this pull request
Nov 23, 2019
Caused by flutter#44217
Contributor
|
This seems to caused #45510 and the problem remains still now. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pr moves the pointer event sanitizing away from framework, as well as test code.
Related Issues
#20517
Tests
I removed a bunch of unused test.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?