ModalBarrier and Drawer barrier prevents mouse events#44296
Merged
dkwingsmt merged 6 commits intoflutter:masterfrom Nov 13, 2019
Merged
ModalBarrier and Drawer barrier prevents mouse events#44296dkwingsmt merged 6 commits intoflutter:masterfrom
dkwingsmt merged 6 commits intoflutter:masterfrom
Conversation
Contributor
|
Nice! Have you considered adding this to |
Contributor
Author
|
@shyndman That needs a different approach. I'll do it in another PR. Thanks for reminding though. |
Contributor
|
You're welcome. Happy to see these updates land. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR adds a full-container opaque
MouseRegionto the following widgets in order to prevent widgets behind it reacting to mouse events:ModalBarrierDrawerCheck out related issues to see reason of this change.
How do I make sure they are all cases that need changing? I searched
BlockSemanticsand they are the only usages.Related Issues
ModalRoute(which applies to most common cases), but not its superclasses.Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?