Remove TextRange, export it from dart:ui#44422
Merged
gspencergoog merged 1 commit intoflutter:masterfrom Nov 9, 2019
Merged
Conversation
fluttergithubbot
added
the
framework
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Contributor
Author
|
Build failures are expected, will be fixed after engine change lands. |
gspencergoog
force-pushed
the
remove_text_range
branch
2 times, most recently
from
2b87a1e to
4c5d6bd
Compare
gspencergoog
force-pushed
the
remove_text_range
branch
from
4c5d6bd to
d8377db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This removes
TextRangefrom the framework and moves it to the engine, in preparation for using it to return text ranges from the text extent APIs, and updates the APIs that useParagraph.getWordBoundary(there was only one) to expect aTextRangeor a pair ofints temporarily until the engine side returns TextRanges, so that I can convert over without breaking the builds.I'll add the engine roll into this PR as soon as flutter/engine#13747 has landed and is green in the engine.
I have successfully run the CI tests locally with the updated engine.
Tests
Breaking Change