Merged
Conversation
Contributor
Author
|
@abarth Given the issues I had with this patch, it might be worth you giving it a once-over again. |
Contributor
There was a problem hiding this comment.
How do we decide whether to include this check? In this case, I suspect it doesn't make it faster.
Contributor
Author
There was a problem hiding this comment.
We should probably do an audit. I agree that this is a case where we shouldn't have it. It makes sense to have it when you're frequently reusing objects, or when the objects are really complex (ThemeData, for instance).
Filed #4447
Contributor
|
|
Also, make sure that the parent is notified when they change. Fixes flutter#2298
cdotstout
pushed a commit
to cdotstout/flutter
that referenced
this pull request
Apr 3, 2018
* fix an off-by-one when the offset itself is a word boundary * lazily create the word break iterator
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, make sure that the parent is notified when they change.
Fixes #2298