Show a warning when a module uses a v1 only plugin#44499
Merged
xster merged 5 commits intoflutter:masterfrom Nov 11, 2019
Merged
Show a warning when a module uses a v1 only plugin#44499xster merged 5 commits intoflutter:masterfrom
xster merged 5 commits intoflutter:masterfrom
Conversation
fluttergithubbot
added
the
tool
xster
commented
Nov 9, 2019
Member
Author
There was a problem hiding this comment.
@zoeyfan to double check on the wording here.
blasten
reviewed
Nov 11, 2019
There was a problem hiding this comment.
Trivial nit: maybe move this closer to where is used.
Member
Author
There was a problem hiding this comment.
Sure, isModule happens to just be a pre-populated map key check, so it could be done in the loop
blasten
reviewed
Nov 11, 2019
There was a problem hiding this comment.
what about a project that was created with v1 and ran make-host-app-editable?
Member
Author
There was a problem hiding this comment.
Discussed on chat. If users generally consumed v1 in add-to-app, it would break in the next stable. Those plugins will need to be registered manually since our tools can't predict whether a v1 or v2 style consumption will be made in the host Android project.
Document in #36491
xster
force-pushed
the
v1-plugin-warning
branch
from
3d8e551 to
52b9726
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since v1 plugins can make incorrect assumptions when used in add-to-app, show a warning when they're being imported.
Related Issues
Fixes #44245
Fixes #44423
Tests
I added the following tests:
added tests in plugin_test
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?