Skip to content

[ci] Use the latest Cirrus Image for macOS #44576

Merged
christopherfujino merged 3 commits intoflutter:masterfrom
fkorotkov:patch-1
Nov 11, 2019
Merged

[ci] Use the latest Cirrus Image for macOS #44576
christopherfujino merged 3 commits intoflutter:masterfrom
fkorotkov:patch-1

Conversation

@fkorotkov
Copy link
Contributor

Description

mojave-flutter is an alias to the latest image with Xcode and Flutter preinstalled. Right now it points to mojave-xcode-11.2.1-flutter images which has Xcode 11.2.1 and the latest stable Flutter.

Tests

All CI checks

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

- sudo gem install bundler -v 2.0.2 -N
- bundle install --system --gemfile=dev/ci/mac/Gemfile
- bundle --version
- sudo bundle install --system --gemfile=dev/ci/mac/Gemfile
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because now the latest Ruby is installed via Homebrew rather then using the system one.

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino
Copy link
Contributor

Landing on red because currently all mac tests are failing on master because of an infra update.

@christopherfujino christopherfujino merged commit 82a92af into flutter:master Nov 11, 2019
@fkorotkov fkorotkov deleted the patch-1 branch November 11, 2019 18:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants