Turn on bitcode for integration tests and add-to-app templates#44633
Merged
jmagman merged 1 commit intoflutter:masterfrom Nov 13, 2019
Merged
Turn on bitcode for integration tests and add-to-app templates#44633jmagman merged 1 commit intoflutter:masterfrom
jmagman merged 1 commit intoflutter:masterfrom
Conversation
jmagman
added
a: tests
fluttergithubbot
added
the
c: contributor-productivity
dnfield
approved these changes
Nov 12, 2019
Contributor
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
This LGTM, although it would be good for @digiter and @chinmaygarde to verify that the devicelab and engine builders will stay in sync. As best I can tell, devicelab is currently all on 11.x and one instance of 10.3, and engine builders are on 10.2
Contributor
|
You may need to merge up to head or something for the arb conflicts? Hans would probably know more. |
…es (flutter#42958)" This reverts commit 41c02d7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 41c02d7.
Description
Turn back on bitcode for integration tests and the add-to-app templates.
Related Issues
Installation bitcode issues seem to be fixed with flutter/engine#13428.