Skip to content

Check in new diffs to material localizations#44736

Merged
gspencergoog merged 1 commit intoflutter:masterfrom
gspencergoog:fix_localizations
Nov 12, 2019
Merged

Check in new diffs to material localizations#44736
gspencergoog merged 1 commit intoflutter:masterfrom
gspencergoog:fix_localizations

Conversation

@gspencergoog
Copy link
Contributor

Description

Trying to fix the localizations.

@fluttergithubbot fluttergithubbot added a: internationalization Supporting other languages or locales. (aka i18n) f: material design flutter/packages/flutter/material repository. labels Nov 12, 2019
@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@DanTup
Copy link
Contributor

DanTup commented Nov 12, 2019

These seem to match what's in the files (for ex. https://github.com/flutter/flutter/blob/master/packages/flutter_localizations/lib/src/l10n/material_zh_TW.arb) but they haven't changed recently, I don't understand what caused this 🤔

@gspencergoog
Copy link
Contributor Author

@DanTup, you're not alone: This fixes the build, but we still have no idea why... We're trying to figure out where the non-determinism is sneaking in.

@DanTup
Copy link
Contributor

DanTup commented Nov 12, 2019

Is it too late to take back a LGTM?

@gspencergoog
Copy link
Contributor Author

LOL, yeah sorry, it's too late. The up side is that Shi-Hao has follow-on PR that maybe removes the non-determinism.

@gspencergoog gspencergoog deleted the fix_localizations branch November 12, 2019 21:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: internationalization Supporting other languages or locales. (aka i18n) f: material design flutter/packages/flutter/material repository.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants