Sort Localization generation output#44743
Merged
shihaohong merged 3 commits intoflutter:masterfrom Nov 12, 2019
shihaohong:sort-generated-localizations
Merged
Sort Localization generation output#44743shihaohong merged 3 commits intoflutter:masterfrom shihaohong:sort-generated-localizations
shihaohong merged 3 commits intoflutter:masterfrom
shihaohong:sort-generated-localizations
Conversation
- When creating locales that were assumed from existing locales, the file that is used is non-deterministic. This adds a sort to the iterator to ensure that the same existing locale is used to generate the assumed locale - When generating material, cupertino and date localizations, the generated getters were not sorted. This introduces an alphabetic sort
shihaohong
added
f: material design
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
fluttergithubbot
added
the
c: contributor-productivity
Contributor
gspencergoog
left a comment
gspencergoog
left a comment
There was a problem hiding this comment.
Why did you add dev/snippets/lib/main.dart.snapshot? I don't think that should be checked in.
Contributor
Author
|
That was a mistake (and not sure where that came from). I just removed it |
gspencergoog
approved these changes
Nov 12, 2019
Contributor
Author
|
Landing on red to fix the tree! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
file that is used is non-deterministic. This adds a sort to the iterator
to ensure that the same existing locale is used to generate the assumed
locale
Related Issues
Fixes #44728
Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?