Skip to content

Ensure web-server does not force usage of dwds#44744

Merged
jonahwilliams merged 4 commits intoflutter:masterfrom
jonahwilliams:fix_web_server
Nov 12, 2019
Merged

Ensure web-server does not force usage of dwds#44744
jonahwilliams merged 4 commits intoflutter:masterfrom
jonahwilliams:fix_web_server

Conversation

@jonahwilliams
Copy link
Contributor

Description

Due to the use of a type check, a change in the API went unnoticed. Added a test case to verify.

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 12, 2019
Copy link
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cc @ferhatb who faced this issue too.

@jonahwilliams jonahwilliams merged commit 2779361 into flutter:master Nov 12, 2019
@jonahwilliams jonahwilliams deleted the fix_web_server branch November 12, 2019 23:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants