Always link desktop platforms#44753
Merged
jonahwilliams merged 3 commits intoflutter:masterfrom Nov 12, 2019
Merged
Conversation
fluttergithubbot
added
the
tool
zanderso
reviewed
Nov 12, 2019
| // Force linking of the platform for desktop embedder targets since these | ||
| // do not correctly load the core snapshots in debug mode. | ||
| // See https://github.com/flutter/flutter/issues/44724 | ||
| bool forceLinkPlatform; |
Member
There was a problem hiding this comment.
bool forceLinkPlatform = false or set to false in the default case of the switch.
| await const KernelSnapshot().build(androidEnvironment | ||
| ..defines[kTargetPlatform] = 'darwin-x64' | ||
| ..defines[kBuildMode] = 'debug' | ||
| ); |
Member
There was a problem hiding this comment.
This test doesn't look like it's testing anything.
Contributor
Author
There was a problem hiding this comment.
Hidden on line 226
alexmarkov
approved these changes
Nov 12, 2019
Contributor
alexmarkov
left a comment
alexmarkov
left a comment
There was a problem hiding this comment.
LGTM assuming it's a temporary workaround.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The desktop shells are not correctly loading the prebuilt core snapshots. This requires the platform to be linked in order to work in debug mode.
See #44724