Canonicalize locale string in gen_l10n.dart#44758
Merged
shihaohong merged 4 commits intoflutter:masterfrom Nov 13, 2019
shihaohong:canonicalize-locale-string
Merged
Canonicalize locale string in gen_l10n.dart#44758shihaohong merged 4 commits intoflutter:masterfrom shihaohong:canonicalize-locale-string
gen_l10n.dart#44758shihaohong merged 4 commits intoflutter:masterfrom
shihaohong:canonicalize-locale-string
Conversation
shihaohong
added
the
a: internationalization
fluttergithubbot
added
the
c: contributor-productivity
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
HansMuller
approved these changes
Nov 12, 2019
dev/tools/localization/gen_l10n.dart
Outdated
| ]; | ||
|
|
||
| for(String pluralKey in pluralIds.keys) { | ||
| for (String pluralKey in pluralIds.keys.toList()..sort()) { |
Contributor
There was a problem hiding this comment.
I don't think we need to sort pluralIds (which should be const instead of final). It's a LinkedHashMap so the order of the keys is stable and matches the order they were defined in.
Contributor
Author
|
I mistakenly added some extra code from a separate branch into this PR. I just removed those lines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Canonicalize locale string in
gen_l10n.dartscript to help try and correct the locale value if possible.