Skip to content

Sort locales and method/properties/getters alphabetically#44761

Merged
shihaohong merged 2 commits intoflutter:masterfrom
shihaohong:sort-localizations-gen-l10n
Nov 13, 2019
Merged

Sort locales and method/properties/getters alphabetically#44761
shihaohong merged 2 commits intoflutter:masterfrom
shihaohong:sort-localizations-gen-l10n

Conversation

@shihaohong
Copy link
Contributor

Description

  1. Minimize the number of diffs for Flutter developers using this tool by:
  • Sorting message properties/methods/getters generated by the gen_l10n.dart script alphabetically
  • Sorting locales based on .arb String paths alphabetically
  1. Update examples/stocks to reflect alphabetical sorting

@shihaohong shihaohong added the a: internationalization Supporting other languages or locales. (aka i18n) label Nov 12, 2019
@fluttergithubbot fluttergithubbot added d: examples Sample code and demos c: contributor-productivity Team-specific productivity, code health, technical debt. labels Nov 12, 2019
@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shihaohong shihaohong merged commit 0d34813 into flutter:master Nov 13, 2019
@shihaohong shihaohong deleted the sort-localizations-gen-l10n branch January 8, 2020 05:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: internationalization Supporting other languages or locales. (aka i18n) c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants