Revert "Implement PageView using SliverLayoutBuilder, Deprecate RenderSliverFillViewport (#37024)"#44778
Merged
LongCatIsLooong merged 4 commits intoflutter:masterfrom Nov 15, 2019
Merged
Conversation
fluttergithubbot
added
the
framework
…rSliverFillViewport (flutter#37024)" This reverts commit 9aea03f.
LongCatIsLooong
force-pushed
the
revert-37024
branch
from
d5fa2a4 to
a993d08
Compare
Member
|
Can you add to the PR description why we are reverting this? Also: If we revert this we will have to re-open the bugs that were closed by that PR. Also: The change has been part of many releases. I am a little afraid that reverting this fix will break people unexpectedly when they upgrade flutter to a release that contains this revert. |
goderbauer
reviewed
Nov 13, 2019
| } | ||
| } | ||
|
|
||
| /// This method can be called to filter the list of available semantic actions, |
Member
There was a problem hiding this comment.
The changes in this file should not be reverted, I think. They are fixing another unrelated problem, no?
goderbauer
approved these changes
Nov 13, 2019
| expect(tester.getTopLeft(find.text('Hawaii')), const Offset(-100.0, 0.0)); | ||
| }); | ||
|
|
||
| testWidgets( |
Member
There was a problem hiding this comment.
Is this one a test case that's worth keeping since this is expected to work in either implementation?
LongCatIsLooong
added a commit
to LongCatIsLooong/flutter
that referenced
this pull request
Nov 15, 2019
…te RenderSliverFillViewport (flutter#37024)" (flutter#44778)" This reverts commit 851d699.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 9aea03f. The said commit introduced a ~4.5% regression in stock_build_iteration microbenchmark.
Related Issues
#39060
Reopens #23873
Reopens #27744
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?