Skip to content

Forward ProcessException to error handlers#44783

Merged
blasten merged 6 commits intoflutter:masterfrom
blasten:forward_process_exception
Nov 13, 2019
Merged

Forward ProcessException to error handlers#44783
blasten merged 6 commits intoflutter:masterfrom
blasten:forward_process_exception

Conversation

@blasten
Copy link

@blasten blasten commented Nov 13, 2019

Description

Forwards Permission denied to the error handlers.

Tests

I added the following tests: Unit test

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 13, 2019
@blasten blasten force-pushed the forward_process_exception branch from b8eb9cd to 2096815 Compare November 13, 2019 01:28
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Emmanuel Garcia and others added 2 commits November 12, 2019 21:11
@blasten blasten merged commit f766871 into flutter:master Nov 13, 2019
@blasten blasten deleted the forward_process_exception branch November 13, 2019 18:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants