Skip to content

Add clip behaviour to Container#44971

Merged
fluttergithubbot merged 22 commits intoflutter:masterfrom
sahandevs:add-clip-behaviour-to-container
Dec 3, 2019
Merged

Add clip behaviour to Container#44971
fluttergithubbot merged 22 commits intoflutter:masterfrom
sahandevs:add-clip-behaviour-to-container

Conversation

@sahandevs
Copy link
Contributor

@sahandevs sahandevs commented Nov 15, 2019 •
edited
Loading

Description

resolves #14421
moved #43564 here because of the mess

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label Nov 15, 2019
@sahandevs sahandevs mentioned this pull request Nov 15, 2019
Closed
9 tasks
@sahandevs
Copy link
Contributor Author

sahandevs commented Nov 15, 2019

@goderbauer I added getClipPath to Decoration and it works with BoxDecoration and ShapeDecoration

Piinks
Piinks reviewed Nov 15, 2019
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sahandevs, Thanks for sticking with this! 🙂

@sahandevs
Copy link
Contributor Author

sahandevs commented Nov 16, 2019

@Piinks I've fixed the issues you've mentioned but I don't know why flutter-build is failing

trietbui85
trietbui85 reviewed Nov 16, 2019
View reviewed changes
trietbui85
trietbui85 reviewed Nov 16, 2019
View reviewed changes
Piinks
Piinks reviewed Nov 25, 2019
View reviewed changes
goderbauer
goderbauer reviewed Nov 25, 2019
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work on this!

The new methods added to BoxDecoration and ShapeDecoration also require tests.

@sahandevs
Copy link
Contributor Author

sahandevs commented Nov 26, 2019

added Tests and fixed formatting/comments

@sahandevs sahandevs requested a review from goderbauer November 27, 2019 06:23
goderbauer
goderbauer approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after comments are resolved.

@goderbauer
Copy link
Member

goderbauer commented Nov 27, 2019

(assuming that all tests pass)

@sahandevs
Copy link
Contributor Author

sahandevs commented Nov 28, 2019

@goderbauer It should be ok now but I don't know why framework_tests-misc-windows is failing

@Piinks
Copy link
Contributor

Piinks commented Dec 2, 2019

Hi @sahandevs I would recommend updating your branch with changes from master to see if that resolves the test failure.

@Piinks
Copy link
Contributor

Piinks commented Dec 3, 2019

Fab! It looks like we can land this once the tree is green. 🎉

@fluttergithubbot fluttergithubbot merged commit f68cdac into flutter:master Dec 3, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Piinks Piinks Piinks left review comments

@goderbauer goderbauer goderbauer approved these changes

+1 more reviewer

@trietbui85 trietbui85 trietbui85 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Container.clipBehavior to clip to the decoration

6 participants

@sahandevs @goderbauer @Piinks @trietbui85 @googlebot @fluttergithubbot