Add macOS hot reload test#45264
Merged
jonahwilliams merged 4 commits intoflutter:masterfrom Nov 20, 2019
Merged
Conversation
fluttergithubbot
added
the
c: contributor-productivity
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| @@ -0,0 +1,14 @@ | |||
| // Copyright 2016 The Chromium Authors. All rights reserved. | |||
| description: > | ||
| Checks the functionality and performance of hot reload on a macOS target platform | ||
| stage: devicelab | ||
| required_agent_capabilities: ["mac/ios"] |
Contributor
There was a problem hiding this comment.
Is it possible to also add "mac/android", "mac/ios32", "mac/iphonexs" since this could run on any of those? That would give the test a wider choice of machines to run on and allow more throughput.
Ideally, the devicelab would be able to just take "mac" as a required agent capability.
Contributor
Author
There was a problem hiding this comment.
I think the match logic is "all of" and not "one of", but it should probably be updated to account for this
added 2 commits
November 20, 2019 10:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Runs the same hot reload test/benchmark that we do on iOS/Android on macOS. Adds a flutter clean step before running to clear any copied xcode caches.
#42281
FYI @godofredoc @digiter