Update spline calculations#45914
Merged
jonahwilliams merged 1 commit intoflutter:masterfrom Dec 3, 2019
Merged
Conversation
fluttergithubbot
added
the
tool
zanderso
approved these changes
Dec 2, 2019
Zazo032
reviewed
Dec 2, 2019
|
|
||
| test('flutter web help string', () { | ||
| expect(flutterWebFeature.generateHelpMessage(), 'Enable or disable Flutter for web. This setting will take effect on the master and dev channels.'); | ||
| expect(flutterWebFeature.generateHelpMessage(), 'Enable or disable Flutter for web. This setting will take effect on the master, dev, and beta channels.'); |
Contributor
Author
There was a problem hiding this comment.
I will defend the Oxford comma until my dying breath
Member
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
Nevermind I didn't know this is something almost mandatory in American English, lesson learned
jonahwilliams
pushed a commit
to jonahwilliams/flutter
that referenced
this pull request
Dec 9, 2019
(cherry picked from commit b63683b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Calculating....