Deprecate UpdateLiveRegionEvent#45940
Merged
fluttergithubbot merged 8 commits intoflutter:masterfrom Dec 3, 2019
Merged
Conversation
dnfield
added
framework
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
dnfield
force-pushed
the
deprecate_live_region_event
branch
from
ed8d8e0 to
c50d4ad
Compare
…ter into deprecate_live_region_event
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Deprecates
UpdateLiveRegionEvent, which was never implemented on the Android or iOS bridges. Updates documentation related to it to clarify current behavior.I cannot find any usage of this API internally - and anyone who tried to use it would probably have filed a bug since it doesn't do anything!
Related Issues
fixes #45936
Tests
I added the following tests:
None. This code is untested, and I'm not sure we have value in testing that it remains deprecated.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?