[flutter_tool] Do not continue with a no-op 'upgrade'#46011
Merged
tvolkert merged 1 commit intoflutter:masterfrom Dec 4, 2019
zanderso:no-op-upgrade-no-welcome
Merged
[flutter_tool] Do not continue with a no-op 'upgrade'#46011tvolkert merged 1 commit intoflutter:masterfrom zanderso:no-op-upgrade-no-welcome
tvolkert merged 1 commit intoflutter:masterfrom
zanderso:no-op-upgrade-no-welcome
Conversation
zanderso
added
the
tool
Contributor
There was a problem hiding this comment.
Should we trace here that we've stopped the upgrade?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If the result of the
git pull --ffduring theflutter upgradecommand lands us on the exact same channel and revision, then do not continue with the rest of the upgrade.Related Issues
#46004
Tests
I added the following tests:
Added a test to upgrade_test.dart
Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?