only run codecov on master#46100
Merged
fluttergithubbot merged 2 commits intoflutter:masterfrom Dec 4, 2019
Merged
Conversation
tvolkert
reviewed
Dec 4, 2019
Contributor
tvolkert
left a comment
tvolkert
left a comment
There was a problem hiding this comment.
This change looks ok, but it wasn't this Cirrus shard that is failing on beta - it's codecov/patch and codecov/project
tvolkert
approved these changes
Dec 4, 2019
Contributor
tvolkert
left a comment
tvolkert
left a comment
There was a problem hiding this comment.
After discussing with @christopherfujino, LGTM!
Contributor
Author
chatted offline, the end of the tool_coverage shard test uploads a report to the codecov service, which then triggers a test on their server, and results in a codecov github check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only run tool_coverage test shard on master, which should in turn lead to codecov only evaluating master commits. We only really care about running on master, and we don't want unreliable red checks to mark release builds.
Fixes #46098.