Skip plugins that don't have an android impl when building AARs#46835
Merged
blasten merged 1 commit intoflutter:masterfrom Dec 12, 2019
Merged
Skip plugins that don't have an android impl when building AARs#46835blasten merged 1 commit intoflutter:masterfrom
blasten merged 1 commit intoflutter:masterfrom
Conversation
fluttergithubbot
added
the
tool
amirh
reviewed
Dec 12, 2019
| assert(pluginDirectory.existsSync()); | ||
|
|
||
| final String pluginName = pluginParts.first; | ||
| if (!pluginDirectory.childDirectory('android').existsSync()) { |
Contributor
There was a problem hiding this comment.
nit: should we check for a android/build.gradle instead to trigger less FNs?
Author
There was a problem hiding this comment.
well. detecting a valid Gradle project requires checking additional files. Is that what we want or just Android-platform support? I think the current definition of that is an 'android' directory.
Contributor
There was a problem hiding this comment.
I see your point, I mentioned it as I thought we'd want to be consistent with what we've done here: #40640
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the tool builds the plugins as AAR, it doesn't skip plugins that don't have an android implementation.
Related Issues
#46807
#46790
Tests
I added the following tests: Unit test.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].