Revert "Use platform appropriate filepaths"#47395
Merged
fluttergithubbot merged 2 commits intoflutter:masterfrom Dec 19, 2019
Merged
Revert "Use platform appropriate filepaths"#47395fluttergithubbot merged 2 commits intoflutter:masterfrom
fluttergithubbot merged 2 commits intoflutter:masterfrom
Conversation
…ndle (flutter#44221)" This reverts commit 383e90e.
fluttergithubbot
added
the
tool
zanderso
reviewed
Dec 19, 2019
| final PoolResource resource = await pool.request(); | ||
| try { | ||
| final File file = fs.file(outputDirectory.uri.resolve(entry.key)); | ||
| final File file = fs.file(fs.path.join(outputDirectory.path, entry.key)); |
Member
There was a problem hiding this comment.
The test is great, but this line and the one in bundle.dart should have some explanatory comments.
Contributor
Author
There was a problem hiding this comment.
I'll open another PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #44221
This introduced #46163
Fixes #46163