Skip to content

Revert "implicit-casts: false"#47428

Merged
chingjun merged 1 commit intomasterfrom
revert-47199-implicit-casts-false
Dec 19, 2019
Merged

Revert "implicit-casts: false"#47428
chingjun merged 1 commit intomasterfrom
revert-47199-implicit-casts-false

Conversation

@chingjun
Copy link
Contributor

@chingjun chingjun commented Dec 19, 2019

Reverts #47199

It failed analyzer and is blocking engine roll.

@chingjun chingjun requested a review from a14n December 19, 2019 07:51
@fluttergithubbot fluttergithubbot added a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Dec 19, 2019
@chingjun
Copy link
Contributor Author

chingjun commented Dec 19, 2019

Landing the revert TBR since it's blocking engine roll, and this is the last commit before the revert.

@a14n
Copy link
Contributor

a14n commented Dec 19, 2019

The breakage should be fixed by #47426 (just waiting pre-submit check to land)

@chingjun chingjun merged commit a485878 into master Dec 19, 2019
@a14n
Copy link
Contributor

a14n commented Dec 19, 2019

:'(

@chingjun
Copy link
Contributor Author

chingjun commented Dec 19, 2019

Oops, I clicked the button a bit too early, sorry.

@a14n a14n mentioned this pull request Dec 19, 2019
Merged
9 tasks
@dnfield dnfield deleted the revert-47199-implicit-casts-false branch December 19, 2019 08:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@a14n a14n Awaiting requested review from a14n

Assignees

No one assigned

Labels

a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chingjun @a14n @googlebot @fluttergithubbot